Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1219] Allow coin selection of 0 value coins #19162

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Quexington
Copy link
Contributor

There was a bad heuristic in the coin selection algorithm to check for a lack of coins. This fixes that and adds a test to make sure that 0 value coins can be selected.

@Quexington Quexington marked this pull request as ready for review January 21, 2025 15:45
@Quexington Quexington requested a review from a team as a code owner January 21, 2025 15:45
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jan 21, 2025
@Quexington Quexington closed this Jan 21, 2025
@Quexington Quexington reopened this Jan 21, 2025
Copy link

Pull Request Test Coverage Report for Build 12895448216

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 37 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.001%) to 91.513%

Files with Coverage Reduction New Missed Lines %
chia/plotters/plotters.py 1 90.94%
chia/full_node/full_node_api.py 1 84.38%
chia/wallet/wallet_node.py 1 88.25%
chia/consensus/blockchain.py 2 94.14%
chia/timelord/timelord_launcher.py 2 89.29%
chia/full_node/full_node.py 4 86.22%
chia/server/node_discovery.py 6 80.77%
chia/plotters/madmax.py 6 44.58%
chia/timelord/timelord.py 14 78.2%
Totals Coverage Status
Change from base Build 12894248841: -0.001%
Covered Lines: 105324
Relevant Lines: 114913

💛 - Coveralls

@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Jan 24, 2025
@pmaslana pmaslana merged commit 223d42f into main Jan 27, 2025
713 of 717 checks passed
@pmaslana pmaslana deleted the quex.zero_coin_selection branch January 27, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants